Skip to content

Clear diagnostic markers after file is closed #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Dec 17, 2016

When a user closes a file in a workspace, the extension does not clear the diagnostic markers corresponding to the closed file from the Problems window in vscode.

Fixes PowerShell/vscode-powershell#314

When a user closes a file in a workspace, the extension did not clear the diagnostic markers corresponding to the closed file from the Problems window.
@kapilmb
Copy link
Author

kapilmb commented Dec 17, 2016

Also fixes PowerShell/vscode-powershell#329

@daviwil
Copy link
Contributor

daviwil commented Dec 17, 2016

Theoretically we shouldn't have to do this, but I don't see any harm in it. Thanks!

@daviwil daviwil merged commit ed05df2 into develop Dec 17, 2016
@daviwil daviwil added this to the 0.8.1 milestone Dec 17, 2016
@daviwil daviwil deleted the kapilmb/clear-problems-window branch December 17, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants