Fix #221: Occasional init hang in LanguageServer #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue in the LanguageServer where the length of time that it takes to evaluate the extension API script can cause the "initialize" request to not complete. This leaves the VS Code language server client in an initializing state where no language features will work for the rest of the session. The fix is to execute the extension API script after the "initialize" handler has been registered.
|
This one was pretty dumb, I was executing the extension API script before registering message handlers. This caused the handler to be registered after that script finishes. On some machines the "initialize" event would come before the script finished execution which meant that there would never be a handler available to respond to that request. |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Move away from deprecated language configuration settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue in the LanguageServer where the length of time
that it takes to evaluate the extension API script can cause the
"initialize" request to not complete. This leaves the VS Code language
server client in an initializing state where no language features will
work for the rest of the session. The fix is to execute the extension API
script after the "initialize" handler has been registered.
This change is