Code

Integrating class symbol support#1984

Code

Merged

andyleejordan merged 80 commits intomainPowerShell/PowerShellEditorServices:mainfrom

andschwa/better-symbolsPowerShell/PowerShellEditorServices:andschwa/better-symbolsCopy head branch name to clipboard

Feb 2, 2023

Commits

Commits on Jan 24, 2023

• add symbols for classes

  

  fflaten

  authored and

  andyleejordan

  committed
  7270bed

  Copy full SHA for 7270bed

• remove code used for supporting PSv3 and v4

  

  fflaten

  authored and

  andyleejordan

  committed
  69a66bb

  Copy full SHA for 69a66bb

• support hover

  

  fflaten

  authored and

  andyleejordan

  committed
  e3845e8

  Copy full SHA for e3845e8

• add type reference symboltype

  

  fflaten

  authored and

  andyleejordan

  committed
  b1187b9

  Copy full SHA for b1187b9

• support references and definitions

  

  fflaten

  authored and

  andyleejordan

  committed
  7cf22f0

  Copy full SHA for 7cf22f0

• add codelens for class and enum

  

  fflaten

  authored and

  andyleejordan

  committed
  13adfc3

  Copy full SHA for 13adfc3

• skip function ast visit for FunctionMemberAst

  

  fflaten

  authored and

  andyleejordan

  committed
  f2be365

  Copy full SHA for f2be365

• drop reference-support for ConfigurationDefinition

  

  fflaten

  authored and

  andyleejordan

  committed
  1d1b5cc

  Copy full SHA for 1d1b5cc

• update document symbols test

  

  fflaten

  authored and

  andyleejordan

  committed
  50e8a6c

  Copy full SHA for 50e8a6c

• refactor and cleanup

  

  fflaten

  authored and

  andyleejordan

  committed
  4c3a4ab

  Copy full SHA for 4c3a4ab

• fix Contains extension method for same line extent

  

  fflaten

  authored and

  andyleejordan

  committed
  ad58bcd

  Copy full SHA for ad58bcd

• add EnumMember, signature and fix detection

  

  fflaten

  authored and

  andyleejordan

  committed
  12b1366

  Copy full SHA for 12b1366

• update symbols test with name position

  

  fflaten

  authored and

  andyleejordan

  committed
  884fecb

  Copy full SHA for 884fecb

• check type for property and function members

  

  fflaten

  authored and

  andyleejordan

  committed
  109dbb0

  Copy full SHA for 109dbb0

• add symbolsservice tests

  

  fflaten

  authored and

  andyleejordan

  committed
  e776984

  Copy full SHA for e776984

• add codelens tests

  

  fflaten

  authored and

  andyleejordan

  committed
  4be7724

  Copy full SHA for 4be7724

• add symbol tests using newline after keyword

  

  fflaten

  authored and

  andyleejordan

  committed
  bca3de0

  Copy full SHA for bca3de0

• fix DSC symbol test

  

  fflaten

  authored and

  andyleejordan

  committed
  da2ad17

  Copy full SHA for da2ad17

• Minor clean-ups

  andyleejordan

  committed
  98fbfbd

  Copy full SHA for 98fbfbd

• Remove deprecated (and confusing) `DocumentSymbolService.cs` file

  andyleejordan

  committed
  3eebb45

  Copy full SHA for 3eebb45

• Rename overloaded method to `ScanForReferencesOfSymbol`

  Show description for 6469411
  andyleejordan

  committed
  6469411

  Copy full SHA for 6469411

• Migrate `FindReferencesVisitor` to `ReferenceTable.ReferenceVisitor`

  Show description for cf79fd0
  andyleejordan

  committed
  cf79fd0

  Copy full SHA for cf79fd0

• Deduplicate `GetSymbolKind`, `GetDecoratedSymbolName`, and `GetRangeFromScriptRegion`

  Show description for a335897
  andyleejordan

  committed
  a335897

  Copy full SHA for a335897

• Move reference sorting to unit tests

  Show description for fe3a37e
  andyleejordan

  committed
  fe3a37e

  Copy full SHA for fe3a37e

• More simplification and dead code elimination

  andyleejordan

  committed
  b17059d

  Copy full SHA for b17059d

• Track declarations on `SymbolType` so we can use `ReferenceTable` more

  Show description for 3a3059f
  andyleejordan

  committed
  3a3059f

  Copy full SHA for 3a3059f

• Integrate `FindSymbolsVisitor` into `ReferenceTable`

  Show description for c67f9ee
  andyleejordan

  committed
  c67f9ee

  Copy full SHA for c67f9ee

• Actually fix sorting in symbols tests

  Show description for db48839
  andyleejordan

  committed
  db48839

  Copy full SHA for db48839

• Make `DocumentSymbolHandler` more readable

  Show description for fd95218
  andyleejordan

  committed
  fd95218

  Copy full SHA for fd95218

• Fix outline view (filter out `EmptyScriptExtent`)

  Show description for 07e566d
  andyleejordan

  committed
  07e566d

  Copy full SHA for 07e566d

• Fix typo

  andyleejordan

  committed
  85694a3

  Copy full SHA for 85694a3

• Replace `FindDeclarationVisitor`

  andyleejordan

  committed
  5776d20

  Copy full SHA for 5776d20

• Remove notion of `ReferencedFiles`

  Show description for 63b2143
  andyleejordan

  committed
  63b2143

  Copy full SHA for 63b2143

• Break the soon-to-be-only visitor out

  andyleejordan

  committed
  cd8dd7f

  Copy full SHA for cd8dd7f

• Remove `FindCommandVisitor`, `FindSymbolVisitor` and `FindDotSourcedVisitor`

  Show description for 6652213
  andyleejordan

  committed
  6652213

  Copy full SHA for 6652213

• Replace `VisitCommandParameter` with `VisitParameter`

  andyleejordan

  committed
  9a857ea

  Copy full SHA for 9a857ea

• Mark Pester symbols as declarations

  andyleejordan

  committed
  e5cf5bd

  Copy full SHA for e5cf5bd

• Clean up `SymbolReference` constructors

  andyleejordan

  committed
  8c2c9c4

  Copy full SHA for 8c2c9c4

• Fix file names for visitors

  andyleejordan

  committed
  cee7033

  Copy full SHA for cee7033

Commits on Jan 25, 2023

• Clean up some `IEnumerables`

  Show description for 6b093da
  andyleejordan

  committed
  6b093da

  Copy full SHA for 6b093da

• Add `DisplayName` to clean up outline

  andyleejordan

  committed
  57c563b

  Copy full SHA for 57c563b

• Exclude parameters from workplace symbols

  andyleejordan

  committed
  74c4382

  Copy full SHA for 74c4382

• Optionally open all workspace files and scan for symbols

  andyleejordan

  committed
  8410180

  Copy full SHA for 8410180

Commits on Jan 26, 2023

• Use `NameRegion` for definition, workplace jump and hover

  andyleejordan

  committed
  c2169ed

  Copy full SHA for c2169ed

• Fix jump to definition from outline

  Show description for f1fc140
  

  andyleejordan

  and

  fflaten

  committed
  f1fc140

  Copy full SHA for f1fc140

• Improve function's display strings

  andyleejordan

  committed
  7471401

  Copy full SHA for 7471401

• Filter symbol references to type matches

  andyleejordan

  committed
  494b0d9

  Copy full SHA for 494b0d9

• Short-circuit find-definition when given definition

  andyleejordan

  committed
  ec8cf7b

  Copy full SHA for ec8cf7b

• Decorate more type names

  Show description for 43baed3
  andyleejordan

  committed
  43baed3

  Copy full SHA for 43baed3

• Include parameter type constraints as symbols

  andyleejordan

  committed
  09fc5d0

  Copy full SHA for 09fc5d0

• Ignore some warnings

  andyleejordan

  committed
  c8a3bb3

  Copy full SHA for c8a3bb3

Commits on Jan 27, 2023

• Fix parameter hints tests (but the whole feature needs work)

  andyleejordan

  committed
  0f1aa19

  Copy full SHA for 0f1aa19

• Fix find function definition tests

  andyleejordan

  committed
  c8abc70

  Copy full SHA for c8abc70

• Fix find variable and function references tests

  andyleejordan

  committed
  2592af9

  Copy full SHA for 2592af9

• Fix `FindsOccurrencesOnParameter` test

  andyleejordan

  committed
  e2d4e25

  Copy full SHA for e2d4e25

• Fix `FindsReferencesOnCommandWithAlias` test

  andyleejordan

  committed
  bd76db3

  Copy full SHA for bd76db3

• Fix a bunch of class symbol tests

  andyleejordan

  committed
  04345dd

  Copy full SHA for 04345dd

• Fix `FindsPropertyDefinition` test

  Show description for 2729e83
  andyleejordan

  committed
  2729e83

  Copy full SHA for 2729e83

• Fix property symbols tests

  andyleejordan

  committed
  b634dfa

  Copy full SHA for b634dfa

• Fix `ScriptRegion.ContainsPosition`

  Show description for e990670
  andyleejordan

  committed
  e990670

  Copy full SHA for e990670

• Fix display string for function definitions

  Show description for e407453
  andyleejordan

  committed
  e407453

  Copy full SHA for e407453

• Fix find enum member tests

  andyleejordan

  committed
  2f93517

  Copy full SHA for 2f93517

• Add symbol type equivalencies test

  andyleejordan

  committed
  fe29524

  Copy full SHA for fe29524

• Remove deprecated dot-source reference tests (and data)

  Show description for f69694c
  andyleejordan

  committed
  f69694c

  Copy full SHA for f69694c

• Fix `FindsDetailsForBuiltInCommand` test

  Show description for aa6bfc7
  andyleejordan

  committed
  aa6bfc7

  Copy full SHA for aa6bfc7

• Fix the rest of the symbols service tests

  andyleejordan

  committed
  1829093

  Copy full SHA for 1829093

• Run `FindsDetailsForBuiltInCommand` only on macOS

  andyleejordan

  committed
  6a21c57

  Copy full SHA for 6a21c57

• Skip `FindsSymbolsInDSCFile` as DSC symbols don't yet work

  Show description for 6d8b0ba
  andyleejordan

  committed
  6d8b0ba

  Copy full SHA for 6d8b0ba

Commits on Jan 28, 2023

• Mark some methods internal

  Show description for fd04c34
  

  andyleejordan

  and

  SeeminglyScience

  authored
  fd04c34

  Copy full SHA for fd04c34

Commits on Jan 31, 2023

• Rename `SymbolReference` fields

  andyleejordan

  committed
  3010065

  Copy full SHA for 3010065

• Replace `SymbolTypeMatches` logic with prefixed identifiers

  Show description for 0135baa
  andyleejordan

  committed
  0135baa

  Copy full SHA for 0135baa

• Strip qualifier from variable name in symbol identifier

  andyleejordan

  committed
  7da6f9d

  Copy full SHA for 7da6f9d

• Handle symbol prefix identifier in `CommandHelpers`

  Show description for 4a90f28
  andyleejordan

  committed
  4a90f28

  Copy full SHA for 4a90f28

• More leniently filter workspace symbols

  Show description for 3b08189
  andyleejordan

  committed
  3b08189

  Copy full SHA for 3b08189

• Map symbol types to LSP better

  andyleejordan

  committed
  6d2d5a7

  Copy full SHA for 6d2d5a7

Commits on Feb 1, 2023

• Restore `public ScriptRegion Create(...)` method

  andyleejordan

  committed
  4c1538b

  Copy full SHA for 4c1538b

• Fix bugs in `VisitorUtils` around `LastIndexOf`

  Show description for 9e12670
  andyleejordan

  committed
  9e12670

  Copy full SHA for 9e12670

• Distinguish properties/enums from variables

  andyleejordan

  committed
  0739fc1

  Copy full SHA for 0739fc1

• Distinguish constructors/methods from functions

  andyleejordan

  committed
  4296553

  Copy full SHA for 4296553

• Remove unused code from `Extensions.cs`

  andyleejordan

  committed
  6208b53

  Copy full SHA for 6208b53