Send GitCommitId over GetVersionHandler
#1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andschwa/improve-version-handler
branch
from
4ccbb33 to
0899ed0
Compare
So the client can skip updates for daily and dev builds. Also clean up a little more, the commit ID was not actually being used in the rest of the codebase, and the `DisplayVersion` was dumb.
andyleejordan
force-pushed
the
andschwa/improve-version-handler
branch
2 times, most recently
from
966ee67 to
a36481a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the client can skip updates for daily and dev builds. Also clean up a little more, the commit ID was not actually being used in the rest of the codebase, and the
DisplayVersionwas dumb.Also fix a bug that luckily didn't make it into the release where the Windows PowerShell version was sending its full self, i.e.
5.1.22621.436which cannot be cast to aSemVer.Required for PowerShell/vscode-powershell#4306.