Skip to content

Update link to emacs-lsp lsp-pwsh plugin #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

Update link to emacs-lsp lsp-pwsh plugin #1909

merged 1 commit into from
Sep 1, 2022

Conversation

jidicula
Copy link
Contributor

@jidicula jidicula commented Aug 25, 2022 •
edited
Loading

PR Summary

See title

PR Context

Development has ceased in https://github.com/kiennq/lsp-powershell, and the README there now points to lsp-pwsh.el in the Emacs-LSP project.

@jidicula
Update link to emacs-lsp lsp-pwsh plugin
1756517 
Development has ceased in https://github.com/kiennq/lsp-powershell, and the README there now points to `lsp-pwsh.el` in the Emacs-LSP project.
@jidicula jidicula requested a review from a team as a code owner August 25, 2022 21:29
@andyleejordan
Copy link
Member

Thanks! I'll go ahead and merge this, but for what it's worth, the CI end-to-end test I added for Emacs uses Eglot!

@andyleejordan andyleejordan enabled auto-merge (squash) September 1, 2022 17:04
@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Sep 1, 2022
@andyleejordan andyleejordan merged commit 889018f into PowerShell:main Sep 1, 2022
@jidicula jidicula deleted the patch-1 branch September 1, 2022 17:45
@jidicula
Copy link
Contributor Author

jidicula commented Sep 1, 2022

Thanks! I'll go ahead and merge this, but for what it's worth, the CI end-to-end test I added for Emacs uses Eglot!

Incredible, I've been wrestling with getting Eglot working with Powershell in Codespaces so this e2e test config is a godsend. Thank you!!

@andyleejordan
Copy link
Member

I'm planning to make it much, much easier to configure PSES with various LSP clients. Right now it just takes way too many finicky CLI flags in my opinion. Hopefully can work on that this month!

@jidicula
Copy link
Contributor Author

jidicula commented Sep 1, 2022

I'm planning to make it much, much easier to configure PSES with various LSP clients. Right now it just takes way too many finicky CLI flags in my opinion. Hopefully can work on that this month!

Oh that would be awesome, I'll keep an eye out for when this lands!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Ignore Exclude from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jidicula @andyleejordan