Skip to content

Rename "Integrated Console" to "Extension Terminal" #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

andyleejordan
Copy link
Member

Except the startup banner as its the default, and may not be for the VS Code extension but for any client that connects to PSES and supports a terminal.

Part of PowerShell/vscode-powershell#4053.

@andyleejordan andyleejordan requested a review from a team July 22, 2022 22:46
@andyleejordan andyleejordan requested a review from a team as a code owner July 22, 2022 22:46
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Extension Terminal labels Jul 22, 2022
@andyleejordan
Copy link
Member Author

@JustinGrote did I miss anything here too?

@andyleejordan andyleejordan force-pushed the andschwa/rename-terminal branch from 5a6d786 to 88d192d Compare July 25, 2022 15:54
Except the startup banner as its the default, and may not be for the VS
Code extension but for any client that connects to PSES and supports a
terminal.

And bump problematic test timeouts up.
@andyleejordan andyleejordan force-pushed the andschwa/rename-terminal branch from 88d192d to 62502ff Compare July 25, 2022 16:20
@@ -117,7 +117,7 @@ public sealed class EditorServicesConfig

public string StartupBanner { get; set; } = @"

=====> PowerShell Integrated Console <=====
=====> PowerShell Editor Services <=====
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default banner, not the one used by the extension.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 932d3b2 into main Jul 25, 2022
@andyleejordan andyleejordan deleted the andschwa/rename-terminal branch July 25, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants