Fix #99: 'using module' relative path resolution #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue with relative module path resolution with the 'using module' statement in more recent versions of PowerShell v5. A new method overload was added to the PowerShell API's Parser.ParseInput method which allows the script's path to be specified. By using this parameter, the PowerShell parser resolves relative module paths correctly. This change also required a change to how PowerShell API usage is verified for different PowerShell versions. Since the PowerShell v5 reference assemblies don't (yet) contain Parser.ParseInput overload, we now have to make a distinction between the PowerShell v5 which is specified by the reference assemblies and the one that is currently shipped in the latest official Windows 10 release (10586). Once updated reference assemblies have been shipped for PowerShell v5 we may revisit this approach.
This change updates appveyor.yml to use the new AppVeyor image that includes WMF 5.0 RTM. This is needed for a small API change that intruduced after WMF 5.0 Production Preview.
|
I'm going to verify that this works against a Windows 10 RTM machine before I merge it. |
|
Seems to be working fine on Win 10 RTM with PowerShell 5.0.10240.16410 |
daviwil
added a commit
that referenced
this pull request
Mar 8, 2016
Fix #99: 'using module' relative path resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with relative module path resolution with the
'using module' statement in more recent versions of PowerShell v5. A new
method overload was added to the PowerShell API's Parser.ParseInput method
which allows the script's path to be specified. By using this parameter,
the PowerShell parser resolves relative module paths correctly.
This change also required a change to how PowerShell API usage is verified
for different PowerShell versions. Since the PowerShell v5 reference
assemblies don't (yet) contain Parser.ParseInput overload, we now have to
make a distinction between the PowerShell v5 which is specified by the
reference assemblies and the one that is currently shipped in the latest
official Windows 10 release (10586). Once updated reference assemblies
have been shipped for PowerShell v5 we may revisit this approach.