WIP: Wrap ReadLine
with lock and fallback to legacy when re-entering
#1729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just me trying things. So, weird thing, but in the repro for PowerShell/vscode-powershell#3751, while we're in the debugger, things can't print. Like if you run
Get-Process
at the debug prompt it shows nothing, and if you're debugging the pwsh process you see a million exceptions. This gets resolved when I set the host explicitly in the newPSInvocationSettings
. When we either don't create the linked cancellation token source, or when we move its scope outside the function its currently created in, the repro issue goes away. The monitor logic I guess is useless 🥲Play around with it @SeeminglyScience?