WIP: Marshal Script-based ToString to PS Execution Pipeline for Performance #1688
Conversation
| ExecutionOptions.Default, | ||
| (_) => | ||
| { | ||
| var existingRunspace = Runspace.DefaultRunspace; |
There was a problem hiding this comment.
I'm just curious why you need to save, change, and then reset the runspace?
There was a problem hiding this comment.
@SeeminglyScience can comment but I think it's just a safety/idempotency thing, in all likelihood it's the same runspace so this effectively doesn't do anything.
There was a problem hiding this comment.
Hm, if that's something we need to do perhaps we should do it in a wrapper? Like, where/when else might we have to do something like that?
And if we're not sure that we have to do it, I'd rather leave a TODO for now so if we encounter a bug we fix it later.
There was a problem hiding this comment.
Yeah that was a troubleshooting step that didn't do anything right? If so that can be removed for sure.
|
@JustinGrote was this something you're still working on? |
|
I haven't been able to find the issue so at the moment, no :) |
|
@andschwa I think I may abandon this PR in favor of the lazy variable inititialization if it is a scriptproperty like Typescript does it, seems like the better way to go. |
|
Hey, sounds good, I think that's the way to go too. |
|
Going to close this out as I did practically the same thing in #1975. |
#1686