Fix: Add special EscapePowershellArgument handling - MOVED to 1611 #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string Fixes #1608 Apply suggested Rosyln Fix
JustinGrote
changed the title
|
@andschwa @rjmholt OK, this works for me, but I question the wisdom of being "overly helpful" on the argument escaping, I think it will just set up editors for failure in the future by submitting commands that are syntactically incorrect but we "fix for them" and then when they try to run those commands in some other context, they fail. Should we not just return some sort of invalid syntax error instead to the client so that they are able to submit it right the first time? CC @SeeminglyScience for his opinion as well |
This was referenced Nov 1, 2021
|
I have a weird uppercase lowercase branch thing happening that is messing with this PR, will resubmit as new PR. |
JustinGrote
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has moved to #1611