Skip to content

Fix incorrect ErrorAction values #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix incorrect ErrorAction values #1575

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2021

I noticed in the logs of my editor's Language Server Protocol client that PowerShellEditorServices was throwing errors from commands with -ErrorAction Ignore in them. I checked to be sure, and Ignore isn't the correct value; SilentlyContinue does that.

I searched the codebase and fixed the three instances of the Ignore value I found.

@ghost ghost requested review from andyleejordan and rjmholt as code owners September 29, 2021 15:15
@ghost
Copy link

ghost commented Sep 29, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ alexbuzzbee sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost
Copy link
Author

ghost commented Sep 29, 2021

I'm reasonably confident these changes aren't copyrightable, but I'll get permission from whoever needs to approve this on my company's side and sign it later.

@andyleejordan
Copy link
Member

Just FYI @alexbuzzbee we really appreciate the PR, but all of these are getting changed in some major overhaul work currently under review. This will likely end up with a merge conflict (but also no longer be needed), so I'm going to close it, but thank you! If you have the inclination, look at #1459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant