Skip to content

Pass InitialSessionState instead of LanguageMode #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dkattan
Copy link
Contributor

@dkattan dkattan commented Jul 13, 2021

No description provided.

@andyleejordan
Copy link
Member

I like, I like. We should move the setting of execution policy to bypass in the ISS to happen only in the test factory, since it shouldn't be necessary otherwise.

dkattan added 4 commits July 13, 2021 20:12
…the Create method used in production to prevent tests from failing when it restores the machine's execution policy.
…sary for the modules to load in E2E tests and production.
@dkattan
Copy link
Contributor Author

dkattan commented Jul 14, 2021

I like, I like. We should move the setting of execution policy to bypass in the ISS to happen only in the test factory, since it shouldn't be necessary otherwise.

Done! All tests pass.

@dkattan dkattan marked this pull request as ready for review July 14, 2021 21:30
@dkattan dkattan requested a review from rjmholt as a code owner July 14, 2021 21:30
@rjmholt
Copy link
Contributor

rjmholt commented Jul 20, 2021

Closing in favour of #1526

@rjmholt rjmholt closed this Jul 20, 2021
@andyleejordan
Copy link
Member

Thanks @dkattan!

@dkattan dkattan deleted the pass-initialsessionstate-instead-of-languagemode branch July 20, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants