Updated Semantic Handler to work with new LSP #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 10:41
rjmholt
reviewed
Aug 4, 2020
| @@ -1162,7 +1162,7 @@ await PsesLanguageClient | |||
| var expectedArr = new int[5] | |||
| { | |||
| // line, index, token length, token type, token modifiers | |||
| 0, 0, scriptContent.Length, 2, 0 //function token: line 0, index 0, length, type 2 = keyword, no modifiers | |||
| 0, 0, 8, 1, 0 //function token: line 0, index 0, length 8, type 1 = keyword, no modifiers | |||
There was a problem hiding this comment.
Is 8 not the length of the script content here?
rjmholt
approved these changes
Aug 4, 2020
| @@ -91,7 +91,7 @@ private async Task CheckPackageManagement() | |||
|
|
|||
| if (_powerShellContextService.CurrentRunspace.Runspace.SessionStateProxy.LanguageMode != PSLanguageMode.FullLanguage) | |||
| { | |||
| _languageServer.Window.ShowWarning("You have an older version of PackageManagement known to cause issues with the PowerShell extension. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`"); | |||
| _languageServer.Window.LogWarning("You have an older version of PackageManagement known to cause issues with the PowerShell extension. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`"); | |||
There was a problem hiding this comment.
This doesn't seem right... the spec says there's a ShowMessage and a LogMessage...
@david-driscoll did this API change?
There was a problem hiding this comment.
yep, I deleted one to many methods!
There was a problem hiding this comment.
I will bring those back and get 0.17.4 out to fix that.
There was a problem hiding this comment.
as a work around for the moment you can use ShowMessage and give it the correct message type.
There was a problem hiding this comment.
New package is out, this should restore that function.
https://www.nuget.org/packages/OmniSharp.Extensions.LanguageServer/0.17.4
TylerLeonhardt
approved these changes
Aug 5, 2020
src/PowerShellEditorServices/Services/TextDocument/Handlers/PsesSemanticTokensHandler.cs
Outdated
Show resolved
Hide resolved
…esSemanticTokensHandler.cs Co-authored-by: Tyler James Leonhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PsesSemanticTokensHandler was not compatible with the Omnisharp.Extensions.LanguageServer update to 0.17.3 following the new LSP spect (v3.18). This PR fixes those issues.
Also see: PowerShell/vscode-powershell#2861