Return null when Hover request is cancelled or no symbol details #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we returned a new Hover instance without initializing the
Contents
orRange
members. At least in VS Code, this will result in the LSP client attempting to accessnull
properties. As we're not returning any Hover data, the correct response is to simply returnnull
. See the Hover Request (Response) section in the LSP spec.To reproduce the issue in VS Code:
Contents
property of the Hover instance.