Fix for issue #123, wildcard chars in script path prevent breakpoints… #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reakpoints from working. Once I got breakpoints to be able to set for files like foo[1].ps1 and foo][.ps1 I noticed that the script named foo][.ps1 would not execute at all!! You get an error saying something like the specified wildcard character pattern is not valid. FWIW ISE fails with this same message. So PSES has one up on ISE. :-)
| /// </summary> | ||
| /// <param name="path">The path to process.</param> | ||
| /// <returns>The path with [ and ] escaped.</returns> | ||
| public static string EscapeWilcardsInPath(string path) |
There was a problem hiding this comment.
Not a big deal, but slight typo here: EscapeWildcardsInPath
There was a problem hiding this comment.
Also I'd say this method probably belongs in PowerShellContext rather than DebugService since it may have more general utility
|
Thanks for catching that typo. I'll fix that. Yeah, I wondered where to put that static and dithered between PowerShellContext and DebugService. :-) |
daviwil
added a commit
that referenced
this pull request
Feb 3, 2016
…litpath Fix for issue #123, wildcard chars in script path prevent breakpoints…
|
Awesome, thanks! Merged. |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…yzer-warnings-buildfile Tweaks to PSake build script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from working.
Once I got breakpoints to be able to set for files like foo[1].ps1 and foo][.ps1 I noticed that the script named foo][.ps1 would not execute at all!! You get an error saying something like the specified wildcard character pattern is not valid. FWIW ISE fails with this same message. So PSES has one up on ISE. :-)