Skip to content

Fix CommentHelp for when a function has other problems with it #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ private static Hashtable GetCommentHelpRuleSettings(string helpLocation, bool fo
{ "BlockComment", forBlockComment },
{ "VSCodeSnippetCorrection", true },
{ "Placement", helpLocation }}
}}
}};
}}},
{ "IncludeRules", "PSProvideCommentHelp" }};
}

#region IDisposable Support
Expand All @@ -505,7 +505,7 @@ protected virtual void Dispose(bool disposing)
{
if (_analysisEngineLazy != null
&& _analysisEngineLazy.IsValueCreated)
{
{
_analysisEngineLazy.Value.Dispose();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -809,9 +809,13 @@ public async Task CanSendGetCommentHelpRequest()
string scriptPath = NewTestFile(@"
function CanSendGetCommentHelpRequest {
param(
[string]
$myParam
$myParam,
$myOtherParam,
$yetAnotherParam
)

# Include other problematic code to make sure this still works
gci
}
");

Expand Down