Skip to content

New colors supported by PS7 (#1064) #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 30, 2019

Backport of #1064.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (included the Linux test failure root caused to it using .NET Core 3.0 SDK)

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs from doing a bunch of CodeFactor and Codacy fixes

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rjmholt and others added 2 commits October 31, 2019 10:53
Co-Authored-By: Steve Lee <[email protected]>
Co-Authored-By: Tyler James Leonhardt <[email protected]>
@rjmholt rjmholt merged commit 8115173 into PowerShell:legacy/1.x Oct 31, 2019
@rjmholt rjmholt deleted the backport/new-colors branch December 11, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants