-
Notifications
You must be signed in to change notification settings - Fork 235
New colors supported by PS7 (#1064) #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (included the Linux test failure root caused to it using .NET Core 3.0 SDK)
src/PowerShellEditorServices/Session/Host/EditorServicesPSHost.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some NITs from doing a bunch of CodeFactor and Codacy fixes
src/PowerShellEditorServices/Session/Host/EditorServicesPSHost.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Steve Lee <[email protected]> Co-Authored-By: Tyler James Leonhardt <[email protected]>
Backport of #1064.