Skip to content

Fix UNC intellisense backslash #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Fix UNC intellisense backslash #1044

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
380bf60
fix UNC intellisense backslash
TylerLeonhardt Sep 26, 2019
1d7222f
use here string
TylerLeonhardt Sep 27, 2019
bf5d765
here everywhere
TylerLeonhardt Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,8 +2010,13 @@ private static CompletionItem CreateCompletionItem(
// This causes the editing cursor to be placed *before* the final quote after completion,
// which makes subsequent path completions work. See this part of the LSP spec for details:
// https://microsoft.github.io/language-server-protocol/specification#textDocument_completion
int len = completionDetails.CompletionText.Length;
completionText = completionDetails.CompletionText.Insert(len - 1, "$0");

// Since we want to use a "tab stop" we need to escape a few things for Textmate to render properly.
var sb = new StringBuilder(completionDetails.CompletionText)
.Replace("\\", "\\\\")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider using a verbatim string here e.g. .Replace(@"\", @"\\") and below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well use verbatim strings on lines 2017 & 2018 as well. Makes the reading of "replaced this with that" easier if you don't have to mentally convert esc sequences. :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yeah that's definitely nit-picking. :-) Overall LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, they're everywhere now - and they're perfectly lined up!

.Replace("}", "\\}")
.Replace("$", "\\$");
completionText = sb.Insert(sb.Length - 1, "$0").ToString();
insertTextFormat = InsertTextFormat.Snippet;
}

Expand Down