Skip to content

Unable to build PSES due to bad version number for PSReadLine #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glennsarti opened this issue Jan 21, 2019 · 5 comments · Fixed by #857
Closed

Unable to build PSES due to bad version number for PSReadLine #855

glennsarti opened this issue Jan 21, 2019 · 5 comments · Fixed by #857
Assignees
Labels

Comments

@glennsarti
Copy link
Contributor

I was trying to build PSES and received the following

PS> Invoke-Build build

.....

C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\6.0\System.IO.Pipes.AccessControl.dll
Done /build/LayoutModule 00:00:07.6917554
Task /build/RestorePsesModules

Restoring EditorServices modules...
        Installing module: PSReadLine with arguments {
    "Name":  "PSReadLine",
    "Repository":  "PSGallery",
    "MaximumVersion":  "2.1",
    "MinimumVersion":  "2.0.0-beta3",
    "Path":  "C:\\Source\\PowerShellEditorServices\\module\\",
    "AllowPrerelease":  true
}
ERROR: Cannot process argument transformation on parameter 'MinimumVersion'. Cannot convert value "2.0.0-beta3" to type "System.Version". Error: "Input string was not in a correct format."
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:490 char:21
+         Save-Module @splatParameters
+                     ~~~~~~~~~~~~~~~~
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:442 char:1
+ task RestorePsesModules -After Build {
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:327 char:1
+ task Build {
+ ~~~~~~~~~~~~
@glennsarti
Copy link
Contributor Author

Windows 10 - 1803
Source - PSES Branch 2.0.0 - Commit 91f9b1a

Full log

Build build C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1
Task /build/SetupDotNet
Done /build/SetupDotNet 00:00:00.2250265
Task /build/CreateBuildInfo
Done /build/CreateBuildInfo 00:00:00.0069832
Task /build
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 27.15 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\PowerShellEditorServices.csproj.
  PowerShellEditorServices -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.dll
  PowerShellEditorServices -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\bin\Debug\netstandard2.0\publish\
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 32.22 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Host\PowerShellEditorServices.Host.csproj.
  Restore completed in 32.2 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\PowerShellEditorServices.csproj.
  Restore completed in 32.26 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\PowerShellEditorServices.Protocol.csproj.
  PowerShellEditorServices -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.dll
  PowerShellEditorServices.Protocol -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.Protocol.dll
  PowerShellEditorServices.Host -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Host\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.Host.dll
  PowerShellEditorServices.Host -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Host\bin\Debug\netstandard2.0\publish\
Microsoft (R) Build Engine version 15.8.169+g1ccb72aefa for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 34.02 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Host\PowerShellEditorServices.Host.csproj.
  Restore completed in 34.01 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\PowerShellEditorServices.Protocol.csproj.
  Restore completed in 34.01 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\PowerShellEditorServices.csproj.
  Restore completed in 34.06 ms for C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.VSCode\PowerShellEditorServices.VSCode.csproj.
  PowerShellEditorServices -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.dll
  PowerShellEditorServices.Protocol -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.Protocol.dll
  PowerShellEditorServices.Host -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.Host\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.Host.dll
  PowerShellEditorServices.VSCode -> C:\Source\PowerShellEditorServices\src\PowerShellEditorServices.VSCode\bin\Debug\netstandard2.0\Microsoft.PowerShell.EditorServices.VSCode.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.31
Task /build/LayoutModule
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\Desktop\System.Security.Principal.Windows.dll
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\Desktop\System.Security.AccessControl.dll
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\Desktop\System.IO.Pipes.AccessControl.dll
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\6.0\System.Security.Principal.Windows.dll
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\6.0\System.Security.AccessControl.dll
C:\Source\PowerShellEditorServices\module\PowerShellEditorServices\bin\6.0\System.IO.Pipes.AccessControl.dll
Done /build/LayoutModule 00:00:00.2670444
Task /build/RestorePsesModules
ERROR: Cannot process argument transformation on parameter 'MinimumVersion'. Cannot convert value "2.0.0-beta3" to type "System.Version". Error: "Input string was not in a correct format."
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:490 char:21
+         Save-Module @splatParameters
+                     ~~~~~~~~~~~~~~~~
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:442 char:1
+ task RestorePsesModules -After Build {
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At C:\Source\PowerShellEditorServices\PowerShellEditorServices.build.ps1:327 char:1
+ task Build {
+ ~~~~~~~~~~~~
Build FAILED. 5 tasks, 1 errors, 0 warnings 00:00:06.5166449

@TylerLeonhardt
Copy link
Member

If you update your version of PowerShellGet to at least like... 1.6 I think... This should go away.

I guess we're not handling the scenario for old versions of PowerShellGet that still ship with Windows PowerShell...

TylerLeonhardt added a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Jan 22, 2019
this also addresses PowerShell#855 by asking the user to get PSGet 1.6.0 or higher PowerShell#855
@TylerLeonhardt
Copy link
Member

I have this throwing the proper error if the user doesn't have PowerShellGet 1.6 or higher. I would install it on behalf of the user... but PowerShellGet is particularly tricky to update.

TylerLeonhardt added a commit that referenced this issue Jan 22, 2019
this also addresses #855 by asking the user to get PSGet 1.6.0 or higher #855
@rkeithhill
Copy link
Contributor

GitHub really needs an Indeed emoji. :-)

@SamB
Copy link

SamB commented May 24, 2019

I think you forgot to update the "Development" instructions in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants