Skip to content

Move folding provider from Extension into Editor Services #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
glennsarti opened this issue Nov 12, 2018 · 0 comments
Open

Move folding provider from Extension into Editor Services #793

glennsarti opened this issue Nov 12, 2018 · 0 comments
Labels
Area-Code Navigation Issue-Enhancement A feature request (enhancement).

Comments

@glennsarti
Copy link
Contributor

A folding provider was added to the VSCode extension initially in PowerShell/vscode-powershell#1355. This issue will track the work to move the folding provider from the extension to the PowerShell Editor Services.

Relates to #527 #377 #228
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 12, 2018
@glennsarti
(PowerShellGH-793) Add simple folding range provider capability
a307a81 
This commit adds the skeleton for a Folding Range Provider.
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 12, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
17f79aa 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 12, 2018
@glennsarti
(PowerShellGH-793)) Add support for Folding Range client settings
90a4efb 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 13, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
b86ce2b 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 13, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
3b90088 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 13, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
691988a 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
@glennsarti glennsarti mentioned this issue Nov 13, 2018
Closed
glennsarti added a commit to glennsarti/vscode-powershell that referenced this issue Nov 13, 2018
@glennsarti
(PowerShellGH-1609) Remove syntax folder provider feature
20b166b 
Now that the PowerShell Editor Services has a Folding Provider, this extension
based feature is no longer required.  This commit removes the feature and tests.

The PSES Issue PowerShell#793 [1] tracks the work to add it to PSES.

[1] PowerShell/PowerShellEditorServices#793
@glennsarti glennsarti mentioned this issue Nov 13, 2018
Merged
4 tasks
@rjmholt rjmholt added Area-Code Navigation Issue-Enhancement A feature request (enhancement). labels Nov 13, 2018
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 14, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
e0dfc4d 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 14, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
61014e1 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 14, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
83b4d14 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 14, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
72dcd9d 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
48c2b75 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
0aa26c4 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Use 2.0 Async method name
9249f46 
This commit renames methods to conform to version 2.0 naming standard;

* Async method names should be suffixed with Async
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
2559ce9 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
8ea8606 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 16, 2018
@glennsarti
(PowerShellGH-793) Use 2.0 Async method name
38b045e 
This commit renames methods to conform to version 2.0 naming standard;

* Async method names should be suffixed with Async
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Add simple folding range provider capability
392f855 
This commit adds the skeleton for a Folding Range Provider.
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
ad51e08 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
c23658f 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Use 2.0 Async method name
6b075cf 
This commit renames methods to conform to version 2.0 naming standard;

* Async method names should be suffixed with Async
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Add a folding provider and tests
bd76cdb 
This commit adds the the code to return folding ranges when the server receives
a FoldingRangeRequest.  This commit;

* Uses a similar method to that implemented in the VS Code extension [1]
* Uses the PowerShell tokeniser instead of the AST.  This is due to the AST
  ignoring comment sections.  Without the comment parsing folding for #region
  etc. will not work
* Translates the tests in VS Code [1] into equivalent C# tests

[1] PowerShell/vscode-powershell#1355
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Add support for Folding Range client settings
77aa878 
This commit uses the the client configuration settings to modify the behaviour
of the server. In particular the Enable and ShowLastLine setting.

* The enable setting will change the provider to return null when disabled
* The ShowLastLine setting emulates the behaviour in PowerShell/vscode-powershell#1557
  * Modifies conversion method for the internal region class to FoldingRange
    object to show/hide the last line based on the extension settings
  * Modifies the tests for the default value and adds tests for the show and hide
    scenarios
glennsarti added a commit to glennsarti/PowerShellEditorServices that referenced this issue Nov 22, 2018
@glennsarti
(PowerShellGH-793) Use 2.0 Async method name
94fdf89 
This commit renames methods to conform to version 2.0 naming standard;

* Async method names should be suffixed with Async
@glennsarti glennsarti mentioned this issue Nov 26, 2018
Open
rjmholt pushed a commit to PowerShell/vscode-powershell that referenced this issue Nov 28, 2018
@glennsarti @rjmholt
Remove syntax-based client-side folder provider (#1610)
79848af 
Now that the PowerShell Editor Services has a Folding Provider, this extension
based feature is no longer required. See PowerShell/PowerShellEditorServices#793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Code Navigation Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glennsarti @rjmholt