Skip to content

Get tests working in PowerShell Core & and Non-Windows #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TylerLeonhardt opened this issue Apr 4, 2018 · 7 comments
Closed

Get tests working in PowerShell Core & and Non-Windows #648

TylerLeonhardt opened this issue Apr 4, 2018 · 7 comments
Assignees
@rjmholt
Labels
Area-General Issue-Enhancement A feature request (enhancement).

Comments

@TylerLeonhardt
Copy link
Member

Right now, we have a ton of stuff hardcoded for Windows PowerShell like:

PowerShellEditorServices/test/PowerShellEditorServices.Test.Host/ServerTestsBase.cs

Line 99 in 1e3234c

FileName = "powershell.exe",

Our tests should support running on Windows PowerShell & PowerShell Core - and be able to run on any OS.
@TylerLeonhardt TylerLeonhardt added Issue-Enhancement A feature request (enhancement). Area-General Up for Grabs Will shepherd PRs. labels Apr 4, 2018
@TylerLeonhardt
Copy link
Member Author

Marking Up-For-Grabs since I think it's relatively trivial, just a bit time consuming.

@glennsarti
Copy link
Contributor

I'll take a crack at this.

@glennsarti
Copy link
Contributor

@tylerl0706 Well, this may be an issue ...

Looks like tests are targetting different .Net versions than the actual code.

e.g. PowerShellEditorServices.Protocol is

<TargetFrameworks>netstandard1.6;net451;</TargetFrameworks>

but the tests are

<TargetFrameworks>netcoreapp2.0;net452</TargetFrameworks>

This will not be an easy fix ...

@SeeminglyScience
Copy link
Collaborator

I could be wrong, but doesn't @rjmholt's netstandard migration PR do this already?

@glennsarti
Copy link
Contributor

Hrmm ok ... yup that looks right.

This will probably be fixed in #741

Not really "Up For Grabs" anymore.

@TylerLeonhardt TylerLeonhardt removed the Up for Grabs Will shepherd PRs. label Oct 1, 2018
@TylerLeonhardt
Copy link
Member Author

Sorry @glennsarti, I've updated the issue

@rjmholt
Copy link
Contributor

rjmholt commented Oct 10, 2018

This has been merged in #741

@rjmholt rjmholt closed this as completed Oct 10, 2018
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
@daviwil
Fix error when debugging untitled script with no launch.json
9bf0c23 
This change fixes an issue which causes and error to appear in the
integrated console when debugging an untitled file without a launch.json
configuration.  The fix is to use the full Uri path when crafting a
launch config for an untitled file.

Resolves PowerShell#648.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjmholt rjmholt

Labels
Area-General Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TylerLeonhardt @glennsarti @rjmholt @SeeminglyScience