Skip to content

"configuration" breaking Syntax Highlighting #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcrotty opened this issue Nov 23, 2015 · 6 comments
Closed

"configuration" breaking Syntax Highlighting #52

bcrotty opened this issue Nov 23, 2015 · 6 comments

Comments

@bcrotty
Copy link

bcrotty commented Nov 23, 2015

2015-11-23 12_56_30-photos

The word "configuration" appears to break syntax highlighting.
@bcrotty
Copy link
Author

bcrotty commented Nov 23, 2015

2015-11-23 12_59_17-c__users_bcrotty_onedrive_script archive_select franchise network discovery ps1

When I take out "configuration", this is what it looks like.

@vors
Copy link
Contributor

vors commented Nov 23, 2015

Hi @bcrotty
Good to see you here :)

PowerShellEditorServices doesn't provide their own syntax highlighting ( @daviwil correct me, if I'm wrong).
Syntax definition for VSCode leaves in https://github.com/SublimeText/PowerShell
So this bug should be probably linked to some bug there.

@daviwil
Copy link
Contributor

daviwil commented Nov 23, 2015

Yep, that's correct. In fact, the syntax highlighting for PowerShell in VS Code is a part of VS Code itself:

https://github.com/Microsoft/vscode/blob/master/extensions/powershell/syntaxes/PowershellSyntax.tmLanguage

However, filing these bugs against vscode-powershell makes sense so that they're tracked in a less noisy place. Also filing them (and fixing them) against the Sublime text repo can't hurt.

@bcrotty
Copy link
Author

bcrotty commented Nov 23, 2015

Thanks! Sorry I haven't been able to contribute recently. I'll post this there as well.

@Jaykul
Copy link

Jaykul commented Nov 24, 2015

I'm not sure if the Sublime repo can serve as the official repository for stuff like this.

Sublime has decided they need a more stateful and testable syntax (LL parser) for this stuff, so they're about to move off .tmLanguage SublimeText/PowerShell#127

@daviwil
Copy link
Contributor

daviwil commented Dec 11, 2015

This issue is now tracked in the SublimeText/PowerShell repo: SublimeText/PowerShell#140

@daviwil daviwil closed this as completed Dec 11, 2015
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
@daviwil
Fix PowerShell#52: Pass /debugAdapter arg directly to host
7fe7c9d 
This change updates the debug adapter registration to remove the need for
the old .cmd hack to launch the PowerShell Editor Services host process
with the /debugAdapter flag.  VS Code 0.10.7 has been fixed so that
arguments in the debug adapter registration get passed through to the host
process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daviwil @Jaykul @vors @bcrotty