Skip to content

Add new 'context' parameter to EvaluateRequest #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daviwil opened this issue Nov 20, 2015 · 1 comment
Closed

Add new 'context' parameter to EvaluateRequest #47

daviwil opened this issue Nov 20, 2015 · 1 comment
Labels
Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Nov 20, 2015

The VS Code team has added a new 'context' parameter to the EvaluateRequest which allows us to determine whether the request comes from the watch window or the REPL. This makes it easier to know whether a request should be evaluated against the current variables list or executed against the runspace.

microsoft/vscode#252

We'll need to add this parameter at some point before the next VS Code release.

@daviwil daviwil changed the title Add new 'context' parameter to EvaluateExpressionRequest Add new 'context' parameter to EvaluateRequest Nov 20, 2015
@daviwil daviwil added this to the 0.3.0 milestone Nov 20, 2015
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Nov 20, 2015
@daviwil
Copy link
Contributor Author

daviwil commented Dec 13, 2015

Looked into this briefly a couple days ago, would require bringing back some logic to walk a variable expression to gather its contents. I'm going to hold off on this temporarily until I have more time to look at it.

@daviwil daviwil modified the milestones: 0.4.0, 0.3.0 Dec 31, 2015
@daviwil daviwil closed this as completed in 13c3274 Jan 5, 2016
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
PowerShell.RunSelection improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

1 participant