-
Notifications
You must be signed in to change notification settings - Fork 235
Give Users the Option to order their Editor Commands or create a "Favorite" option to force to top. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think I'd ultimately prefer to just have the commands sorted alphabetically just like the main command list just so that we don't need the added complexity of allowing user-configured favorites. The better option would be getting the PowerShell-based editor commands inserted into the main command list so that they're accessible from keybindings, etc. If there's a command that you use so often that you want it at the top of the editor commands list then you probably want a hotkey bound to it instead. |
So far Alt + p has been working out awesome for me. The only issue, is an already open bug, which is having it work in any context. |
I think what I am beginning to notice, is we might start to see a ton of Commands. I like have the options of being able to see the list of commands, so as long as they can be seen from the main list still I like the idea. What I have started to notice though, is I am already starting to change how I write commands. I am needing to condense them into a selection instead of say 3 individual commands. We may not have that option if its a Module Author writing the commands. Meaning, if these become popular, you may have to really sort to find your command that you use most. |
I have been thinking of a few ideas.
Some of these can be fixed in my own commands by just prefixing the names, but then it might get out of hand when others start adding commands. |
Sorting by Maybe it's better to file a separate item for that feedback so that it's tracked? |
I will do that later tonight. |
I'm not sure we need this as much now that we have the Integrated Console. Thoughts? |
I think we need to keep this around. This is more of a VSCode extension GUI issue i.e. how we display the list of editor commands when someone executes: |
Right but how many additional commands do people typically have? If it's like 2-3, we probably don't need this feature. But if people typically have a decent amount, it sounds like a valid ask. I think maybe I don't quite understand what this feature is suppose to do/be used for. Are the commands usually editor specific? |
@tylerl0706 it's for extending PSES from PowerShell. Here's some examples https://github.com/SeeminglyScience/EditorServicesCommandSuite |
Currently, Editor Commands are ordered in the list in the order they were loaded. This is fine right now since you can just order them in your profile in the order you want them. However, when more people start adopting Editor Commands and integrating them into their functions and modules, I can see this becoming much more problematic. I am still thinking about how you might integrate this, but I wanted to start a discussion about it.
The other Idea I had was to give the user the ability to mark "Favorite" commands that would place those commands at the top of the list. You could either do this in some form of config file, some form of command you throw in your Profile, or maybe even a switch added to
Register-EditorCommand
. I feel like the later might be abused by Module authors though, unless you did something where it only works if executed from the users profile or something like that.The text was updated successfully, but these errors were encountered: