Message payload types should be registered with MessageParser automatically #2
Assignees
Comments
KeroroLulu
pushed a commit
to KeroroLulu/PowerShellEditorServices
that referenced
this issue
Apr 20, 2018
KeroroLulu
pushed a commit
to KeroroLulu/PowerShellEditorServices
that referenced
this issue
Apr 20, 2018
Supress Warning in Travis PowerShell#2 Test for travis Add Comment XML for travis Add Comment for Testing
KeroroLulu
pushed a commit
to KeroroLulu/PowerShellEditorServices
that referenced
this issue
Apr 20, 2018
Supress Warnings in travis Supress Warning in Travis PowerShell#2 Test for travis Add Comment XML for travis Add Comment for Testing
TylerLeonhardt
pushed a commit
that referenced
this issue
Apr 21, 2018
* Add customize output color enhancement (#651) Supress Warnings in travis Supress Warning in Travis #2 Test for travis Add Comment XML for travis Add Comment for Testing * Adding internal class I added all internal class and suppress all the SuppressMessage. But I can't remove the empty documentation, the analysis of PowerShell Editor Services doesn't let it pass. I tried to add the suppress warning in it but it doesn't work as well. So I had to add all documentation. * Suppress Documentation for internal members Sorry I didn't notice that was only for public members until I read the error again. * Add text for color sumary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now all message types in Transport.Stdio have to be manually added to a dictionary in the MessageParser class before they can be deserialized correctly. A developer also has to set the right payload type name in their Request/Response/Event class' constructor which is quite easy to forget.
A better solution would be to have an attribute on message classes that defines the payload type name and then use reflection to scan for message types with this attribute. Message types that don't have the attribute should raise an assert in debug builds so that the developer knows that they need to add it. This should solve both problems.
The text was updated successfully, but these errors were encountered: