Skip to content

Remove Nito.AsyncEx dependency #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Jan 23, 2016 · 0 comments
Closed

Remove Nito.AsyncEx dependency #115

daviwil opened this issue Jan 23, 2016 · 0 comments
Assignees
@daviwil
Labels
Issue-Enhancement A feature request (enhancement).
Milestone
0.4.0

Comments

@daviwil
Copy link
Contributor

daviwil commented Jan 23, 2016

Nito.AsyncEx is a useful library but including it as a dependency limits the use of PowerShell Editor Services because it requires additional open-source approval. It would be ideal to implement our own async helper classes so that we can remove this dependency.

Here are the classes which would need to be replaced:

  • AsyncContext / AsyncContextThread
  • IAsyncWaitQueue / DefaultAsyncWaitQueue
  • AsyncProducerConsumerQueue
  • AsyncLock
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Jan 23, 2016
@daviwil daviwil self-assigned this Jan 23, 2016
@daviwil daviwil modified the milestones: 0.5.0, 0.4.0 Jan 23, 2016
daviwil added a commit that referenced this issue Jan 25, 2016
@daviwil
Remove Nito.AsyncEx dependency, add replacements
154f7e6 
This change removes all uses of the Nito.AsyncEx NuGet package from the
solution.  This change was made to remove the use of this third-party
dependency so that consumers don't need to get extra open-source approval
when using PowerShell Editor Services.

Removing this dependency required the creation of our own custom
implementations of the classes we were using from Nito.AsyncEx.  These new
classes were written from scratch.

Resolves #115
@daviwil daviwil mentioned this issue Jan 25, 2016
Merged
daviwil added a commit that referenced this issue Jan 25, 2016
@daviwil
Remove Nito.AsyncEx dependency, add replacements
0fe1a84 
This change removes all uses of the Nito.AsyncEx NuGet package from the
solution.  This change was made to remove the use of this third-party
dependency so that consumers don't need to get extra open-source approval
when using PowerShell Editor Services.

Removing this dependency required the creation of our own custom
implementations of the classes we were using from Nito.AsyncEx.  These new
classes were written from scratch.

Resolves #115
dfinke pushed a commit that referenced this issue Jan 26, 2016
@daviwil @dfinke
Remove Nito.AsyncEx dependency, add replacements
75690fc 
This change removes all uses of the Nito.AsyncEx NuGet package from the
solution.  This change was made to remove the use of this third-party
dependency so that consumers don't need to get extra open-source approval
when using PowerShell Editor Services.

Removing this dependency required the creation of our own custom
implementations of the classes we were using from Nito.AsyncEx.  These new
classes were written from scratch.

Resolves #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviwil daviwil

Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@daviwil