Skip to content

PowerShell Core Policy #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 12, 2019
Merged

PowerShell Core Policy #180

merged 19 commits into from
Aug 12, 2019

Conversation

TravisEz13
Copy link
Member

The main goal here is to describe various policy and setting fall-back behavior:

  1. When things like -settingsfile will be allowed to overwrite, what type of settings.
  2. When PowerShell Core will use Windows PowerShell Policy, and how.
  3. Where various policies/settings are read from.

@SteveL-MSFT SteveL-MSFT mentioned this pull request May 31, 2019
TravisEz13 and others added 2 commits May 31, 2019 14:13
Apply suggestions from code review

Co-Authored-By: Ilya <[email protected]>
Update 1-Draft/RFCXXXX-Policy.md
Update 1-Draft/RFCXXXX-Policy.md

Co-Authored-By: Ilya <[email protected]>
@TravisEz13
Copy link
Member Author

@swngdnz FYI, we noticed that another new behavior was accidentally added. I started this based on an existing RFC and I didn't cut enough. Here is the diff: 227f56a

@TravisEz13
Copy link
Member Author

@swngdnz and @iSazonov Thank you for your feedback.

@brettmillerb
Copy link

brettmillerb commented Jun 1, 2019

I've had a quick scan on my phone but should these policy settings allow for configuration of powershell repositories. At present this is an XML file which had to be placed in AppData of a user's profile.

At present this is stored on a per user basis under:
C:\Users\username\AppData\Local\Microsoft\Windows\PowerShell\PowerShellGet and is often a requirement to be configured for all users on various machines.

@TravisEz13
Copy link
Member Author

TravisEz13 commented Jun 3, 2019

@brettmillerb This does not change the format of the file at all. Please review the Goals section for the summary fo the changes in this RFC: https://github.com/PowerShell/PowerShell-RFC/pull/180/files#diff-45c05001a45a6563a6c836a16cc9081cR22

I also, reviewed the RFC and updated it so it does not move the location of any of the configuration file (although another RFC will likely do that.)

@iSazonov
Copy link
Contributor

iSazonov commented Jun 5, 2019

I am trying to find all references to me in 100 comment above :-(

Copy link
Contributor

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I skipped something in comments above.

@iSazonov
Copy link
Contributor

iSazonov commented Jul 2, 2019

I have only one request about startup behavior
#180 (comment) - I hope MSFT team will carefully review this again.
Rest is LGTM.

@joeyaiello
Copy link
Contributor

Quorum-less @PowerShell/powershell-committee reviewed today (@JamesWTruher, @SteveL-MSFT, and me), @JamesWTruher is coming in with a question or two.

@PowerShell PowerShell deleted a comment from JamesWTruher Jul 8, 2019
@joeyaiello
Copy link
Contributor

I'm good with everything here, and I think @PowerShell/powershell-committee should work to get this one merged (today's meeting would be great).


### Settings locations

`PowerShell 7` settings are grouped into `Policy settings` and `Regular settings`.
Copy link
Member

@SteveL-MSFT SteveL-MSFT Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps better to call it Policies and Preferences as Regular settings doesn't provide sufficient context in my view.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean my Preferences here? Preferences has a specific Group Policy meaning. I would suggest avoiding this terminology as it is confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking non-policy settings is a better term

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

@joeyaiello joeyaiello merged commit c1c7c66 into PowerShell:master Aug 12, 2019
@@ -73,7 +73,7 @@ PowerShell 7 does not update configuration values from modified configuration fi

### Settings locations

`PowerShell 7` settings are grouped into `Policy settings` and `Regular settings`.
`PowerShell 7` settings are grouped into `Policy settings` and `Non-policy settings`.
Regular settings are normal configuration settings.
Regular settings can be treated as default and recommended values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Non-policy be used everywhere?

@TravisEz13 TravisEz13 deleted the policy branch August 13, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants