-
Notifications
You must be signed in to change notification settings - Fork 129
PowerShell Core Policy #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apply suggestions from code review Co-Authored-By: Ilya <[email protected]> Update 1-Draft/RFCXXXX-Policy.md Update 1-Draft/RFCXXXX-Policy.md Co-Authored-By: Ilya <[email protected]>
@swngdnz FYI, we noticed that another new behavior was accidentally added. I started this based on an existing RFC and I didn't cut enough. Here is the diff: 227f56a |
@swngdnz and @iSazonov Thank you for your feedback. |
I've had a quick scan on my phone but should these policy settings allow for configuration of powershell repositories. At present this is an XML file which had to be placed in AppData of a user's profile. At present this is stored on a per user basis under: |
@brettmillerb This does not change the format of the file at all. Please review the Goals section for the summary fo the changes in this RFC: https://github.com/PowerShell/PowerShell-RFC/pull/180/files#diff-45c05001a45a6563a6c836a16cc9081cR22 I also, reviewed the RFC and updated it so it does not move the location of any of the configuration file (although another RFC will likely do that.) |
I am trying to find all references to me in 100 comment above :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I skipped something in comments above.
I have only one request about startup behavior |
Quorum-less @PowerShell/powershell-committee reviewed today (@JamesWTruher, @SteveL-MSFT, and me), @JamesWTruher is coming in with a question or two. |
I'm good with everything here, and I think @PowerShell/powershell-committee should work to get this one merged (today's meeting would be great). |
1-Draft/RFCXXXX-Policy.md
Outdated
|
||
### Settings locations | ||
|
||
`PowerShell 7` settings are grouped into `Policy settings` and `Regular settings`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps better to call it Policies
and Preferences
as Regular settings
doesn't provide sufficient context in my view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean my Preferences here? Preferences has a specific Group Policy meaning. I would suggest avoiding this terminology as it is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking non-policy settings
is a better term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment
1-Draft/RFCXXXX-Policy.md
Outdated
@@ -73,7 +73,7 @@ PowerShell 7 does not update configuration values from modified configuration fi | |||
|
|||
### Settings locations | |||
|
|||
`PowerShell 7` settings are grouped into `Policy settings` and `Regular settings`. | |||
`PowerShell 7` settings are grouped into `Policy settings` and `Non-policy settings`. | |||
Regular settings are normal configuration settings. | |||
Regular settings can be treated as default and recommended values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Non-policy
be used everywhere?
The main goal here is to describe various policy and setting fall-back behavior:
-settingsfile
will be allowed to overwrite, what type of settings.