Skip to content

AvoidAlias: deprecate this rule #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rismoney
Copy link

This rule is detrimental to the powershell community as it undermines
foundational idiomatic syntax that enables powershell to be extremely
powerful with simplicity in mind.

It hinders growth in many projects and forces unnecessary
verbosity around widely used simplistic cmdlets.

Microsoft has provided over 150 built-in aliases that are part of the
standard language and their usage should be allowed. If the problem
is conflicts with aliases then they should be worked out in the
powershell project and not here.

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

This rule is detrimental to the powershell community as it undermines
foundational idiomatic syntax that enables powershell to be extremely
powerful with simplicity in mind.

It hinders growth in many projects and forces unnecessary
verbosity around widely used simplistic cmdlets.

Microsoft has provided over 150 built-in aliases that are part of the
standard language and their usage should be allowed. If the problem
is conflicts with aliases then they should be worked out in the
powershell project and not here.
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ rismoney sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@rismoney
Copy link
Author

This is going to require additional work, as I see some other tests reference this, including globalsupression.

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all: Thank you for your efforts and initiative! I appreciate that.
But as per my comment in the referenced issue #214 this needs to be discussed and approved first before this PR can continue because I think this might not be the right direction to go for PSScriptAnalyzer.

@JamesWTruher
Copy link
Contributor

Please feel free to reopen if you choose (or create a new PR). With no activity in the last 6 months or so, this has gone a bit stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants