Skip to content

Fix indentation for multi-line pipelines #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Feb 7, 2017

Resolves PowerShell/vscode-powershell#448


This change is Reviewable

var tempIndentationLevel = indentationLevel;

// Ignore comments
int j = k - 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the - 2 indicate? For "magic numbers" like this, it'd be good to leave a comment to say why it works

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the explanation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That helps, thanks!

@kapilmb kapilmb merged commit f99ae8f into development Feb 7, 2017
@kapilmb kapilmb deleted the kapilmb/indentation-rule-exception branch February 7, 2017 22:46
@kapilmb
Copy link
Author

kapilmb commented Feb 7, 2017

Thanks @daviwil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants