Skip to content

Discover settings file from given path #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2016

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Sep 7, 2016

Partially resolves #518


This change is Reviewable

@kapilmb kapilmb changed the title discover settings file from given path Discover settings file from given path Sep 7, 2016
@raghushantha
Copy link
Member

README.md, line 221 at r1 (raw file):

Note that providing settings explicitly takes higher precedence over this implicit mode. Sample settings files are provided here.

Point to the Settings file in the release branch - aka Master


Comments from Reviewable

@raghushantha
Copy link
Member

Engine/Commands/InvokeScriptAnalyzerCommand.cs, line 38 at r1 (raw file):

        "ScriptAnalyzer",
        DefaultParameterSetName="File",
        HelpUri = "http://go.microsoft.com/fwlink/?LinkId=525914")]

Minor: This help uri redirects to GitHub page. Wondering if a fw link is really required OR we can point to Github directly.


Comments from Reviewable

@raghushantha
Copy link
Member

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@kapilmb
Copy link
Author

kapilmb commented Sep 12, 2016

Review status: 7 of 8 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 221 at r1 (raw file):

Previously, raghushantha (Raghu Shantha [MSFT]) wrote…

Point to the Settings file in the release branch - aka Master

Done.

Comments from Reviewable

@raghushantha
Copy link
Member

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@raghushantha
Copy link
Member

:lgtm:


Comments from Reviewable

@kapilmb
Copy link
Author

kapilmb commented Sep 12, 2016

@raghushantha Thanks!

@kapilmb kapilmb merged commit 650b5c2 into development Sep 12, 2016
@kapilmb kapilmb deleted the kapilmb/SettingsAutoDiscovery branch September 13, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to conclude on precedence Settings files
3 participants