Create PSGalleryRuleProfile #517
Conversation
I've combined the rules sets already in the repo and exclude the script style profile.
|
None of the settings file in the settings folder end with "RuleProfile". May be we can just rename it to PSGallery.psd1? or PSGallerySettings.psd1 because we now prefer to call it settings over profile. |
|
I renamed it to be "PSGallerySettings.psd1" |
|
@joeyaiello @raghushantha What do you guys think of this? Should we have "settings" suffixed for a file PSScriptAnalyzer settings file that will be a part of the Settings/ folder? |
|
We'd like to close on #518 before merging this one so that we don't paint ourselves into a corner with the file naming structure profiles. Is that reasonable? Are there any hard deadlines you're trying to meet with this merge? |
|
I don't have a deadline for this. I would like to finalize the rules we are including in this profile only. Naming the file is not an issue for me. |
|
@KrishnaV-MSFT @rebro-msft What do you think of the rule set and the filename? @joeyaiello I would prefer to get this thing merged and close the PR for now. If need be we will revisit it when we have something conclusive regarding #518 |
|
@yutingc Please change the name to PSGallery.psd1. I think no one mentioned here has any issues with the file's content. So, after you make the name change I will merge this PR. Thanks! |
|
Renamed. |
|
Awesome! Thanks! Reviewed 1 of 3 files at r2, 2 of 2 files at r3. Comments from Reviewable |
I've combined the rules sets already in the repo and exclude the script style profile.
This change is