Skip to content

Updates the Initialize method to process the profile parameter. #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rkeithhill
Copy link
Contributor

We need this capability in the PowerShell extension for VSCode to enable it to use an external settings file. This will allow users of the extension to be able to customize the default settings.

cc @daviwil


This change is Reviewable

We need this capability in the PowerShell extension for VSCode to enable it to use an external settings file.  This will allow users of the extension to be able to customize the default settings.
@daviwil
Copy link
Contributor

daviwil commented Mar 27, 2016

This change will be necessary for PSScriptAnalyzer profile/settings support in VS Code in the short term. I've reviewed the code with Keith already and it looks good to me. What do you guys think?

@raghushantha
Copy link
Member

:lgtm:


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@raghushantha raghushantha merged commit 3571167 into PowerShell:development Mar 28, 2016
@daviwil
Copy link
Contributor

daviwil commented Mar 28, 2016

Thanks Raghu!

@rkeithhill rkeithhill deleted the rkeithhill/initialize-processes-profile branch March 28, 2016 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants