Fix severity inconsistency in AvoidUsingConvertToSecureStringWithPlainText #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2016 15:12
…PlainText rule. The severity showed by Get-ScriptAnalyzerRule and Invoke-ScriptAnalyzer for this rule were different. This was because scriptanalyzer defines two types of severities, viz., RuleSeverity and DiagnosticSeverity and the severity levels were not consistent. This commit makes the severity level consistent by setting them both to Warning.
|
a discussion (no related file): Comments from the review on Reviewable.io |
|
Reviewed 3 of 3 files at r1. Comments from the review on Reviewable.io |
added 4 commits
March 21, 2016 15:36
|
Comments from the review on Reviewable.io |
|
Reviewed 9 of 9 files at r2. Comments from the review on Reviewable.io |
|
Review status: all files reviewed at latest revision, all discussions resolved. a discussion (no related file): Comments from the review on Reviewable.io |
kapilmb
pushed a commit
that referenced
this pull request
Mar 21, 2016
Fix severity inconsistency in AvoidUsingConvertToSecureStringWithPlainText and UseIdenticalParametersDSC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is