Added comment about unary operators and whitespace #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I just merged the fix for the referenced PSSA issue and personally do not see the need to add this to the documentation. |
|
Great that the fix got merged! Good job! Doesn’t matter that much to me, this just raised some discussion (and this section in the guidelines was mentioned, but didn’t really help at all) so I thought it’s better to have the guidelines as clear as possible since they do cover this subject. If it doesn’t feel like it should be merged because it doesn’t provide any meaningful improvement I won’t argue, maybe everyone agrees on this already and we can do without it, that’s all good to me :-) Thanks again for your work on the fix in the PSSA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bug for the PSScriptAnalyzer:
PowerShell/PSScriptAnalyzer#847