Fix linked-list bugs #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In section 17, session 10: - insertLast() crashed if the list was empty - getAt() kept going after finding the requested node - removeAt() crashed if the argument equaled the number of nodes - printListData() added a trailing space separator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In section 17, session 10:
insertLast()crashed if the list was emptygetAt()kept going after finding the requested noderemoveAt()crashed ifindexequaled the number of nodesprintListData()added a trailing space separatorI'm lumping multiple bugs into the same PR because there doesn't appear to be a way to file bug reports, to which I would have linked separate commits/PRs. I'm also ignoring the fact that
getAt()doesn't do what its name says it will do.Not all of the bugs were worth a PR, but with the two crashing bugs, I figured I might as well fix even the minor bugs while I had the code on the bench. 😉