-
Notifications
You must be signed in to change notification settings - Fork 239
Homework done #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
101b1
wants to merge
5
commits into
Otus-Android:development
Choose a base branch
from
101b1:task_3
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
af98c4f
Changed to coroutine with PresenterScope, try-catch exception handling
101b1 1086693
versioned app folder
101b1 0573525
image added, common coroutine cancellation
b5c131c
rewritten to use ViewModel + coroutine exception handler
101b1 40ea807
fixed remark points
101b1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package otus.homework.coroutines | ||
|
||
import com.google.gson.annotations.SerializedName | ||
|
||
data class CatImage( | ||
@field:SerializedName("file") | ||
val fileUrl: String | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package otus.homework.coroutines | ||
|
||
data class CatsModel( | ||
val fact: Fact, | ||
val image: CatImage | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
package otus.homework.coroutines | ||
|
||
import retrofit2.Call | ||
import retrofit2.Response | ||
import retrofit2.http.GET | ||
|
||
interface CatsService { | ||
|
||
@GET("random?animal_type=cat") | ||
fun getCatFact() : Call<Fact> | ||
suspend fun getCatFact() : Response<Fact> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
app/src/main/java/otus/homework/coroutines/CatsViewModel.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
package otus.homework.coroutines | ||
|
||
import androidx.lifecycle.LiveData | ||
import androidx.lifecycle.MutableLiveData | ||
import androidx.lifecycle.ViewModel | ||
import androidx.lifecycle.viewModelScope | ||
import kotlinx.coroutines.CoroutineExceptionHandler | ||
import kotlinx.coroutines.async | ||
import kotlinx.coroutines.launch | ||
import java.lang.Exception | ||
import java.net.SocketTimeoutException | ||
|
||
sealed class Result | ||
|
||
class Success<T>(val data: T) : Result() | ||
class Error(val errorMsg: String) : Result() | ||
|
||
class CatsViewModel( | ||
private val catsService: CatsService, | ||
private val imageService: ImageService | ||
) : ViewModel() { | ||
|
||
private val catInfo: MutableLiveData<Result> = MutableLiveData<Result>() | ||
private val exceptionHandler = CoroutineExceptionHandler() { _, exception -> | ||
when(exception){ | ||
is SocketTimeoutException -> catInfo.value = Error(exception.localizedMessage ?: "An error occurred") | ||
else -> CrashMonitor.trackWarning() | ||
} | ||
} | ||
|
||
init { | ||
loadInfo() | ||
} | ||
|
||
fun getCatInfo(): LiveData<Result> { | ||
return catInfo | ||
} | ||
|
||
private fun loadInfo() { | ||
viewModelScope.launch(exceptionHandler) { | ||
val fact = async { handleResponse(catsService.getCatFact()) } | ||
val image = async { handleResponse(imageService.getRandomImage()) } | ||
catInfo.value = Success<CatsModel>(CatsModel(fact.await(), image.await())) | ||
} | ||
} | ||
|
||
fun onButtonClicked() { | ||
loadInfo() | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
app/src/main/java/otus/homework/coroutines/ImageService.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package otus.homework.coroutines | ||
|
||
import retrofit2.Response | ||
import retrofit2.http.GET | ||
import java.lang.Exception | ||
|
||
|
||
fun <T> handleResponse(response: Response<T>): T{ | ||
if (response.isSuccessful) return response.body()!! | ||
else throw Exception() | ||
} | ||
|
||
interface ImageService { | ||
@GET("meow") | ||
suspend fun getRandomImage() : Response<CatImage> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
app/src/main/java/otus/homework/coroutines/PresenterScope.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package otus.homework.coroutines | ||
|
||
import kotlinx.coroutines.CoroutineName | ||
import kotlinx.coroutines.CoroutineScope | ||
import kotlinx.coroutines.Dispatchers | ||
import kotlin.coroutines.CoroutineContext | ||
|
||
class PresenterScope(): CoroutineScope { | ||
override val coroutineContext: CoroutineContext | ||
get() = Dispatchers.Main + CoroutineName("CatsCoroutine") | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:orientation="vertical" android:layout_width="match_parent" | ||
android:layout_height="match_parent"> | ||
|
||
<TextView | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
android:text="@string/loading" | ||
android:textSize="24sp" | ||
android:textColor="@color/black" | ||
android:textAlignment="center" | ||
android:layout_gravity="center" | ||
android:gravity="center"/> | ||
|
||
</LinearLayout> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
<resources> | ||
<string name="app_name">Cat Facts </string> | ||
<string name="more_facts">More Facts</string> | ||
<string name="no_server_response">Couldn\'t get response from a server.</string> | ||
<string name="loading">Loading...</string> | ||
</resources> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
иначе при отсутствии интернета будет креш