HW_1_Kuzmin #174
Open
HW_1_Kuzmin #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkazakov
requested changes
Nov 6, 2023
| } | ||
|
|
||
| fun onInitComplete() { | ||
| val deferredFact = viewModelScope.async { catsService.getCatFact() } |
There was a problem hiding this comment.
А почему ты их вынес за пределы launch?
| private val _result = MutableLiveData<Result>() | ||
| val result: LiveData<Result> get() = _result | ||
|
|
||
| private val exceptionHandler = CoroutineExceptionHandler { _, throwable -> |
There was a problem hiding this comment.
Предлагаю оставить CoroutineExceptionHandler длдя необработанных исключений, а socketexction обработать через try/catch или runCatching
|
|
||
| viewModelScope.launch(exceptionHandler) { | ||
| val catModel = CatModel(deferredFact.await(), deferredImage.await().first()) | ||
| _result.postValue(Result.Success(catModel)) |
There was a problem hiding this comment.
Ты тут уже на главном потоке, можно setValue вызвать
added_presenter_logic|fixed_e_handling|and_stuff
added_presenter_logic|fixed_e_handling|and_stuff
|
Антон, привет. Внес корректировки. |
antonkazakov
requested changes
Nov 26, 2023
| fun onInitComplete() { | ||
| viewModelScope.launch(exceptionHandler) { | ||
|
|
||
| val deferredFact = withContext(Dispatchers.IO) { |
There was a problem hiding this comment.
Так, а тут же не поправил, у тебя последовательные запросы
|
Распараллелил запросы. |
| } | ||
| } | ||
|
|
||
| val deferredImage = async(Dispatchers.IO) { |
There was a problem hiding this comment.
Можно не переключать диспатчер для таких библиотек как рум и ретрофит и любых других что из коробки сапортят саспенд функции
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.