Homework Baturina #164
Open
Homework Baturina #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkazakov
requested changes
Aug 31, 2023
| override fun onFailure(call: Call<Fact>, t: Throwable) { | ||
| CrashMonitor.trackWarning() | ||
| outerScope.launch { | ||
| innerScope = CoroutineScope(Dispatchers.IO) |
There was a problem hiding this comment.
А иннер скоуп ты зачем делаешь?
| _catsView?.populate(CatModel(catFact.await().fact, catImage.await().url)) | ||
| } catch (exc: SocketTimeoutException) { | ||
| _catsView?.makeToast("Не удалось получить ответ от сервером") | ||
| } catch (exc: Exception) { |
There was a problem hiding this comment.
Здесь будет также пойман CancellationException, через который работает механизм отмены. Нужно его пробросить дальше, либо не ловить такой общий тип исключений
| private val serviceCatImage: CatsService | ||
| ): ViewModel() { | ||
|
|
||
| var result: MutableLiveData<CatsResult> = MutableLiveData() |
There was a problem hiding this comment.
Наружу нужно показывать иммутабельную версию лайвдаты/стейтфлоу
| viewModelScope.launch(exceptionHandler) { | ||
| val catFact = async { serviceCatFact.getCatFact() } | ||
| val catImage = async { serviceCatImage.getCatImage() } | ||
| result.postValue(CatsResult.Success(CatModel(catFact.await().fact, catImage.await().url))) |
There was a problem hiding this comment.
А зачем тут postValue, ты же уже на главный поток вернулась
| } | ||
|
|
||
| fun onInitComplete() { | ||
| viewModelScope.launch(exceptionHandler) { |
There was a problem hiding this comment.
Добавь обработку исключений через try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.