Homework Fedorov #155
Open
Homework Fedorov #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
добавил обработку исключения запроса в сеть передал ошибку на вью, обработал вид исключения, вывел тост согласно заданию обновил гредл, добавил кастомный скоуп, обернул вызов саспенд функций в корутины Переписал логику на саспенд функции Заменил возвращаемый тип в CatService с колбека на датакласс и добавил модификатор suspend Обновил УРЛ сервиса
# Conflicts: # app/src/main/java/otus/homework/coroutines/CatsService.kt
…уя библиотеку Picasso, добавил в метод populate тип для ссылки, добавил зависимость в гредл лайфсайкл скоуп, изменил скоуп в активити с кастомного на lifecycle
Добавил эксепшен хендлер для перехвата ошибок Добавил необходимые зависимости для гредла, создал вью модель, убрал обращение к презентору
invweb
reviewed
Jul 11, 2023
| catsPresenter.detachView() | ||
| } | ||
| super.onStop() | ||
| ViewModelProvider(this)[CatsViewModel::class.java] |
| catsPresenter.detachView() | ||
| } | ||
| super.onStop() | ||
| ViewModelProvider(this)[CatsViewModel::class.java] | ||
| } | ||
| } |
| interface CatsImageService { | ||
| @GET("meow") | ||
| suspend fun getCatImageUrl() : CatsImage | ||
| } |
|
|
||
| @GET("fact") | ||
| suspend fun getCatFact() : Fact | ||
| } |
| } | ||
| return service | ||
| } | ||
| } |
| data class CatsImage( | ||
| @field: SerializedName("url") | ||
| val url:String = "" | ||
| ) |
| ) | ||
| } | ||
| } | ||
| } |
invweb
reviewed
Jul 11, 2023
| } | ||
| } | ||
|
|
||
| interface ICatsView { |
There was a problem hiding this comment.
1 файл - 1 класс или интерфейс, мне кажется, что хорошо придерживать именно такого порядка
invweb
reviewed
Jul 11, 2023
| interface ICatsView { | ||
|
|
||
| fun populate() | ||
| } |
There was a problem hiding this comment.
переноса строки опять нету, гитхаб подсвечивает
invweb
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.