Skip to content

Correct id resolution when absolute uri-reference is used #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #104

@OptimumCode OptimumCode added the fix Fix for bug label May 3, 2024
@OptimumCode OptimumCode enabled auto-merge (squash) May 3, 2024 14:35
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.13%. Comparing base (cdfe7dc) to head (4435807).

Files Patch % Lines
...b/optimumcode/json/schema/internal/SchemaLoader.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   90.13%   90.13%   -0.01%     
==========================================
  Files         119      119              
  Lines        3174     3183       +9     
  Branches      942      944       +2     
==========================================
+ Hits         2861     2869       +8     
  Misses         53       53              
- Partials      260      261       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode merged commit 17277e2 into main May 3, 2024
9 checks passed
@OptimumCode OptimumCode deleted the issue_#104 branch May 3, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: id with absolute uri-reference results in incorrect reference resolution
1 participant