Update Unmanaged+Extension

[Kyle-Ye]

Summary by CodeRabbit

• Refactor

  • Updated internal logic for searching elements in property lists to improve code style without changing behavior.
  • Reorganized and replaced utility methods for handling unmanaged instances, including enhancements to transformation and comparison operations.

• Chores

  • Removed and reintroduced utility extensions for unmanaged instances in a new location, maintaining functionality with slight improvements.

[coderabbitai]

Walkthrough

The changes involve refactoring and relocating utility extensions for the Unmanaged type in Swift. The previous extension file providing map, flatMap, and equality operators for Unmanaged was removed and replaced with a new extension in a different directory, adding similar but slightly expanded functionality. Additionally, the find function in PropertyList.swift was updated to use map instead of flatMap for optional property access, without altering its core logic or behavior. No public API signatures were changed, only internal implementations and code organization.

Changes

File(s)	Change Summary
Sources/OpenSwiftUICore/Data/Property/PropertyList.swift	Updated the find function to use map instead of flatMap for optional property access in three locations.
Sources/OpenSwiftUICore/Data/Property/Unmanaged+Extension.swift	Deleted the file containing the Unmanaged extension with utility map, flatMap, and equality operator implementations.
Sources/OpenSwiftUICore/Extension/Unmanaged+Extension.swift	Added a new extension for Unmanaged with three map overloads and equality/inequality operators, using @_transparent.

Poem

In the warren, code hops anew,
Extensions moved, as rabbits do.
With map and checks for pointer kin,
The garden’s neat, let changes begin!
FlatMap’s gone, new paths are spun—
A tidy burrow for everyone.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7014a2e and 1752631.

📒 Files selected for processing (3)

• Sources/OpenSwiftUICore/Data/Property/PropertyList.swift (1 hunks)
• Sources/OpenSwiftUICore/Data/Property/Unmanaged+Extension.swift (0 hunks)
• Sources/OpenSwiftUICore/Extension/Unmanaged+Extension.swift (1 hunks)

💤 Files with no reviewable changes (1)

• Sources/OpenSwiftUICore/Data/Property/Unmanaged+Extension.swift

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Execute compatibility tests for macOS (macos-15, 16.0, 2024)
• GitHub Check: Execute tests on iOS (macos-15, 16.0, 2024, 18.0)
• GitHub Check: Execute tests on iOS (macos-15, 16.0, 2021, 18.0)
• GitHub Check: Execute tests on macOS (macos-15, 16.0, 2024)
• GitHub Check: Execute tests on Ubuntu (6.0.1)
• GitHub Check: Execute tests on macOS (macos-15, 16.0, 2021)

🔇 Additional comments (7)

Sources/OpenSwiftUICore/Extension/Unmanaged+Extension.swift (5)

8-12: Well-implemented map function for direct value transformation.

This implementation provides a safe way to transform the unmanaged reference into any value type using _withUnsafeGuaranteedRef. The @_transparent attribute is correctly used to encourage inlining for this small function.

---

14-17: Appropriate implementation for object transformation.

This overload correctly handles transforming to another object type, maintaining the unmanaged status while ensuring type safety with the T: AnyObject constraint. Using passUnretained is appropriate here as the method doesn't alter the reference counting.

---

19-22: Proper handling of optional transformation results.

This overload elegantly handles the case where the transformation might return nil, correctly using Swift's optional map on the result to conditionally create an unmanaged reference only when the transform succeeds.

---

24-26: Correct implementation of equality comparison.

Using toOpaque() to compare the underlying pointers is the right approach for implementing equality between unmanaged references, as it correctly checks for identity equality.

---

28-30: Consistent implementation of inequality operator.

The inequality operator correctly leverages the pointer comparison logic, maintaining consistency with the equality operator implementation.

Sources/OpenSwiftUICore/Data/Property/PropertyList.swift (2)

148-148: Correctly updated to use map instead of flatMap.

The change from flatMap to map for accessing the keyFilter property is appropriate and aligns with the new Unmanaged extension implementation. This maintains the same behavior while using a more direct transformation approach.

---

155-155: Properly migrated to use map for property access.

The switch from flatMap to map for accessing the keyType property is consistent with the other changes in this PR. The behavior remains unchanged while leveraging the new extension methods.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 20.90%. Comparing base (7014a2e) to head (1752631).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...penSwiftUICore/Extension/Unmanaged+Extension.swift	40.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   20.87%   20.90%   +0.02%     
==========================================
  Files         337      337              
  Lines       15484    15486       +2     
==========================================
+ Hits         3233     3237       +4     
+ Misses      12251    12249       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.