Skip to content

Replaced Logo with Cropped Rectangular Version (Scale = 1) #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

DineshNehra29
Copy link
Contributor

@DineshNehra29 DineshNehra29 commented Mar 28, 2025

Fixes #465

This PR replaces the current logo with a cropped rectangular version, maintaining a scale of 1. The updated logo ensures a more refined and visually consistent appearance while preserving clarity and aspect ratio.

Screenshots:

Screenshot 2025-03-28 013757
Screenshot 2025-03-28 014230
Screenshot 2025-03-28 014453

Summary by CodeRabbit

  • Style
    • Removed the enlargement effect on the navigation bar logo, resulting in a smaller and more balanced appearance.

Copy link

coderabbitai bot commented Mar 28, 2025

Walkthrough

The change updates the custom CSS file to remove the scale property for the logo within the .navbar-brand class. The previous scale value of 2.0 has been deleted, resulting in the logo reverting to its default size. This adjustment impacts the visual presentation of the logo in the navigation bar.

Changes

File Change Summary
docs/source/_static/custom.css Removed the .navbar-brand scale property set to 2.0

Assessment against linked issues

Objective Addressed Explanation
Create rectangular version of the pyopenms logo for the header (#465)

Suggested reviewers

  • jpfeuffer

Poem

I'm a rabbit with a tiny hop,
In the CSS world, I never stop.
The logo now fits without a scale,
A perfect look, we shall not fail.
With whiskers twitching and code so sweet,
I celebrate this fix with a happy beat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 074319d and d68cbe1.

📒 Files selected for processing (1)
  • docs/source/_static/custom.css (0 hunks)
💤 Files with no reviewable changes (1)
  • docs/source/_static/custom.css
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/source/_static/custom.css (1)

121-124: Review the CSS scale property usage

The new change sets the logo’s scaling with scale: 1.0 on the .navbar-brand img selector. Note that standard CSS for scaling transformations typically uses the transform property, for example:

transform: scale(1.0);

If you are relying on a custom or experimental setup where scale is recognized, please verify that it works consistently across all supported browsers. Otherwise, consider switching to the standard syntax.

-.navbar-brand img {
-    scale: 1.0;
-}
+.navbar-brand img {
+    transform: scale(1.0);
+}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd3aa3b and 074319d.

⛔ Files ignored due to path filters (1)
  • docs/source/img/pyOpenMSlogo_color.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • docs/source/_static/custom.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-test

@@ -120,7 +120,7 @@ p.rubric+dl.py.function {

/* Enlarge logo */
.navbar-brand img {
scale: 2.0
scale: 1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the whole thing. The "enlarge" comment does not make sense anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I'll remove the entire block since the 'enlarge' comment is no longer relevant. Thanks for the clarification!

@jpfeuffer jpfeuffer merged commit c9c4752 into OpenMS:master Mar 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rectangular version of the pyopenms logo for the header
2 participants