-
Notifications
You must be signed in to change notification settings - Fork 66
Replaced Logo with Cropped Rectangular Version (Scale = 1) #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the custom CSS file to remove the scale property for the logo within the Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/source/_static/custom.css (1)
121-124
: Review the CSS scale property usageThe new change sets the logo’s scaling with
scale: 1.0
on the.navbar-brand img
selector. Note that standard CSS for scaling transformations typically uses thetransform
property, for example:transform: scale(1.0);If you are relying on a custom or experimental setup where
scale
is recognized, please verify that it works consistently across all supported browsers. Otherwise, consider switching to the standard syntax.-.navbar-brand img { - scale: 1.0; -} +.navbar-brand img { + transform: scale(1.0); +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/source/img/pyOpenMSlogo_color.svg
is excluded by!**/*.svg
📒 Files selected for processing (1)
docs/source/_static/custom.css
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-test
docs/source/_static/custom.css
Outdated
@@ -120,7 +120,7 @@ p.rubric+dl.py.function { | |||
|
|||
/* Enlarge logo */ | |||
.navbar-brand img { | |||
scale: 2.0 | |||
scale: 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the whole thing. The "enlarge" comment does not make sense anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I'll remove the entire block since the 'enlarge' comment is no longer relevant. Thanks for the clarification!
Fixes #465
This PR replaces the current logo with a cropped rectangular version, maintaining a scale of 1. The updated logo ensures a more refined and visually consistent appearance while preserving clarity and aspect ratio.
Screenshots:
Summary by CodeRabbit