-
Notifications
You must be signed in to change notification settings - Fork 66
Improved Contrast for Function Signatures in Documentation in Dark Theme #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the CSS styling for parameter names in function signatures. Specifically, the color property is modified from Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/source/_static/custom.css (1)
71-74
: Enhanced Parameter Name Contrast
The parameter styling for function signatures has been updated withcolor: #3f87d3
which should improve readability against dark backgrounds. Please ensure that this new color meets the WCAG contrast ratio guidelines for users with visual impairments.
Please show results in light mode, too. |
And please add |
@jpfeuffer I have added light mode screenshots. |
Perfect thanks. |
Fixes #456
Description:
This PR enhances the readability of function signatures in the PyOpenMS documentation in dark theme by increasing the contrast of italicized parameters and type hints. The previous color scheme caused issues where parameters like self, key, and desc blended into the dark background, making them difficult to read.
Current behavior:


After Changes:


Summary by CodeRabbit
This update enhances the visual presentation without any other changes to overall styling or functionality.