Skip to content

Updated to fix an issue where routing wouldn't work correctly #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2018
Merged

Updated to fix an issue where routing wouldn't work correctly #68

merged 1 commit into from
Feb 2, 2018

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll requested a review from tintoy February 2, 2018 01:02
bjorkstromm
bjorkstromm reviewed Feb 2, 2018
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will try to use this and see if my issues still persists.

@david-driscoll
Copy link
Member Author

I have a feeling we will still have a problem with the resolve calls, but this should fix the calls to code lens themselves.

@david-driscoll david-driscoll merged commit 023ac40 into master Feb 2, 2018
@bjorkstromm
Copy link
Member

@david-driscoll yup. this resolved call to CodeLensHandler, but the resolve calls don't work.

@david-driscoll david-driscoll deleted the fix/routing branch June 2, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm left review comments

@tintoy tintoy Awaiting requested review from tintoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-driscoll @bjorkstromm