Skip to content

Fixes #52 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2018
Merged

Fixes #52 #59

merged 3 commits into from
Jan 10, 2018

Conversation

david-driscoll
Copy link
Member

No description provided.

… params. When a null is given we won't error, instead we will just pretend we never got any params at all.
@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #59 into master will decrease coverage by 0.04%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   70.02%   69.98%   -0.05%     
==========================================
  Files         211      211              
  Lines        2202     2209       +7     
==========================================
+ Hits         1542     1546       +4     
- Misses        660      663       +3
Impacted Files Coverage Δ
src/Server/LanguageServer.cs 0% <0%> (ø) ⬆️
src/Server/Handlers/ExitHandler.cs 0% <0%> (ø) ⬆️
src/Server/Handlers/ShutdownHandler.cs 0% <0%> (ø) ⬆️
src/JsonRpc/Reciever.cs 91.66% <100%> (+0.49%) ⬆️
src/JsonRpc/ProcessScheduler.cs 90.9% <0%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde3283...88d900e. Read the comment docs.

@david-driscoll david-driscoll merged commit 1158fd8 into master Jan 10, 2018
@david-driscoll david-driscoll deleted the fix/52 branch June 2, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant