Skip to content

WIP tracing support #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 24, 2021
Merged

WIP tracing support #553

merged 11 commits into from
Apr 24, 2021

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented Apr 1, 2021

Added tracing support with help from StreamJson RPC

@NTaylorMullen
Copy link

Very cool! It's nice to see under the hood and see how this stuff stitches itself together

Copy link

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm glad the vs-streamjsonrpc code helped expedite this.

@github-actions github-actions bot added this to the v0.19.2 milestone Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #553 (e446d4c) into master (12277eb) will decrease coverage by 0.89%.
The diff coverage is 21.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   73.79%   72.90%   -0.90%     
==========================================
  Files         256      257       +1     
  Lines       12373    12577     +204     
  Branches      824      843      +19     
==========================================
+ Hits         9131     9169      +38     
- Misses       3242     3408     +166     
Impacted Files Coverage Δ
src/JsonRpc/Client/OutgoingNotification.cs 100.00% <ø> (ø)
src/JsonRpc/Server/Notification.cs 100.00% <ø> (ø)
src/JsonRpc/Server/Request.cs 100.00% <ø> (ø)
src/JsonRpc/IActivityTracingStrategy.cs 8.12% <8.12%> (ø)
...lization/Converters/ClientNotificationConverter.cs 60.00% <20.00%> (-26.67%) ⬇️
...Serialization/Converters/ClientRequestConverter.cs 62.96% <20.00%> (-25.28%) ⬇️
src/JsonRpc/RequestRouterBase.cs 90.90% <40.00%> (-9.10%) ⬇️
src/Dap.Shared/DebugAdapterRequestRouter.cs 83.33% <100.00%> (ø)
src/JsonRpc/JsonRpcServerOptionsBase.cs 80.00% <100.00%> (+1.25%) ⬆️
src/JsonRpc/OutputHandler.cs 94.87% <100.00%> (+0.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12277eb...e446d4c. Read the comment docs.

@david-driscoll david-driscoll merged commit 005c87f into master Apr 24, 2021
@david-driscoll david-driscoll deleted the feature/tracing branch April 24, 2021 21:07
@github-actions github-actions bot added the mysterious We forgot to label this label Apr 24, 2021
@AArnott
Copy link

AArnott commented Apr 25, 2021

If I had $1 for every PR that completed with "WIP" in the title...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants