-
Notifications
You must be signed in to change notification settings - Fork 105
WIP tracing support #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP tracing support #553
Conversation
Very cool! It's nice to see under the hood and see how this stuff stitches itself together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm glad the vs-streamjsonrpc code helped expedite this.
src/Dap.Protocol/DebugAdapterConverters/DapClientNotificationConverter.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 73.79% 72.90% -0.90%
==========================================
Files 256 257 +1
Lines 12373 12577 +204
Branches 824 843 +19
==========================================
+ Hits 9131 9169 +38
- Misses 3242 3408 +166
Continue to review full report at Codecov.
|
If I had $1 for every PR that completed with "WIP" in the title... |
Added tracing support with help from StreamJson RPC