Move payload deserialisation out of handlers #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the common JsonSerializerSettings can be used by the calling code. NOTE: This code is currently non-functional - handlers have been modified to take an Object instead of a JObject but the calling code does not yet perform deserialisation.
|
I'm wondering whether |
Codecov Report
@@ Coverage Diff @@
## refactor/protocol #53 +/- ##
====================================================
- Coverage 70.11% 70.02% -0.1%
====================================================
Files 211 211
Lines 2202 2202
====================================================
- Hits 1544 1542 -2
- Misses 658 660 +2
Continue to review full report at Codecov.
|
david-driscoll
approved these changes
Dec 19, 2017
|
Ok - I'm going to change it then 😁 |
|
Right, have renamed it and added a couple of tests :) Providing CI checks pass, would you like me to add this work to your WIP branch? |
|
Ok we're good to go :) |
|
@david-driscoll - I'm going to merge this into your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the deserialisation of payloads out of handlers and into the calling code (
LspDispatcher).