Skip to content

Removed Porposal Attributes from everywhere #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Conversation

david-driscoll
Copy link
Member

Spec 3.16 has been released!

Namespaces have changed and Proposals has been removed.

Introduced a new Proposals assembly for both DAP and LSP, these assemblies will house any future proposal classes, this should help avoid making breaking changes to the current protocol versions.

@david-driscoll david-driscoll added the breaking change This breaks existing behavior label Dec 16, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 16, 2020
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #480 (4aebc8e) into master (2055eaa) will increase coverage by 0.34%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   72.73%   73.07%   +0.34%     
==========================================
  Files         254      256       +2     
  Lines       12278    12246      -32     
  Branches      840      838       -2     
==========================================
+ Hits         8930     8949      +19     
+ Misses       3348     3297      -51     
Impacted Files Coverage Δ
src/Client/LanguageClientOptionsExtensions.cs 42.70% <ø> (ø)
src/Server/LanguageServerOptionsExtensions.cs 41.66% <ø> (ø)
...rc/Server/Pipelines/SemanticTokensDeltaPipeline.cs 100.00% <ø> (ø)
...als/Serialization/ProposedCapabilitiesConverter.cs 83.33% <83.33%> (ø)
...l.Proposals/Serialization/ProposedLspSerializer.cs 93.33% <93.33%> (ø)
src/Client/LanguageClient.cs 97.24% <100.00%> (+0.01%) ⬆️
...lient/LanguageClientServiceCollectionExtensions.cs 97.16% <100.00%> (+0.02%) ⬆️
src/JsonRpc/JsonRpcServerOptionsBase.cs 78.48% <100.00%> (ø)
src/JsonRpc/Serialization/SerializerBase.cs 96.77% <100.00%> (+0.77%) ⬆️
src/Protocol.Proposals/ProposedExtensions.cs 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2055eaa...4aebc8e. Read the comment docs.

@david-driscoll david-driscoll added the merge Shipit! label Dec 16, 2020
@david-driscoll david-driscoll merged commit 67b73f1 into master Dec 16, 2020
@mergify mergify bot removed the merge Shipit! label Dec 16, 2020
@mergify mergify bot deleted the update/spec-3.16 branch December 16, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This breaks existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant