Skip to content

Added support for open generic params and handler interfaces. Added ExecuteCommandParams<> #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

david-driscoll
Copy link
Member

Fixes #370

@david-driscoll david-driscoll added the enhancement New feature or request label Dec 15, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 15, 2020
@david-driscoll david-driscoll changed the title Added support for open generic params and handler interfaces. Added support for open generic params and handler interfaces. Added ExecuteCommandParams<> Dec 15, 2020
@david-driscoll david-driscoll added the merge Shipit! label Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #479 (a1c83ab) into master (e797c15) will increase coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   72.67%   72.73%   +0.06%     
==========================================
  Files         254      254              
  Lines       12269    12278       +9     
  Branches      838      834       -4     
==========================================
+ Hits         8917     8931      +14     
+ Misses       3352     3347       -5     
Impacted Files Coverage Δ
...ors/Strategies/ExtensionMethodGeneratorStrategy.cs 100.00% <ø> (ø)
....Generators/Strategies/HandlerGeneratorStrategy.cs 14.51% <ø> (ø)
...tMethodGeneratorWithRegistrationOptionsStrategy.cs 48.11% <ø> (ø)
...thodGeneratorWithoutRegistrationOptionsStrategy.cs 100.00% <ø> (ø)
...eMethodGeneratorWithRegistrationOptionsStrategy.cs 1.85% <ø> (ø)
...thodGeneratorWithoutRegistrationOptionsStrategy.cs 0.00% <ø> (ø)
src/JsonRpc.Generators/Helpers.cs 64.69% <68.42%> (+0.19%) ⬆️
src/JsonRpc.Generators/Contexts/SyntaxSymbol.cs 91.66% <100.00%> (ø)
...nRpc.Generators/GenerateHandlerMethodsGenerator.cs 97.22% <100.00%> (+0.01%) ⬆️
src/JsonRpc/OutputHandler.cs 98.36% <0.00%> (+1.63%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e797c15...a1c83ab. Read the comment docs.

@mergify mergify bot merged commit 2055eaa into master Dec 15, 2020
@mergify mergify bot removed the merge Shipit! label Dec 15, 2020
@mergify mergify bot deleted the fix/gh-370 branch December 15, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace/executeCommand request - return a value
1 participant