Skip to content

Reduce use of Assembly.GetTypes() or ExportedTypes #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

david-driscoll
Copy link
Member

This adds a few generators that emit assembly attributes so that getting access to all the registration converters, and capability keys is working as expected.

… not set it will be provided through [GenerateRegistrationOptions] if provided there
@david-driscoll david-driscoll added enhancement New feature or request merge Shipit! labels Dec 5, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 5, 2020
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #461 (b25380c) into master (d21f232) will decrease coverage by 0.36%.
The diff coverage is 50.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   66.79%   66.42%   -0.37%     
==========================================
  Files         252      254       +2     
  Lines       11913    12186     +273     
  Branches      812      832      +20     
==========================================
+ Hits         7957     8095     +138     
- Misses       3956     4091     +135     
Impacted Files Coverage Δ
.../JsonRpc.Generators/Cache/CachedSourceGenerator.cs 100.00% <ø> (ø)
src/JsonRpc.Generators/Helpers.cs 64.49% <ø> (+2.25%) ⬆️
....Generators/Strategies/HandlerGeneratorStrategy.cs 14.51% <ø> (ø)
src/JsonRpc/JsonRpcServerOptionsExtensions.cs 0.00% <0.00%> (ø)
src/Testing/ClientCapabilityExtensions.cs 6.25% <0.00%> (-0.90%) ⬇️
...erators/AssemblyCapabilityKeyAttributeGenerator.cs 4.10% <4.10%> (ø)
...ators/AssemblyJsonRpcHandlersAttributeGenerator.cs 5.12% <5.12%> (ø)
...DebugAdapterProtocolServiceCollectionExtensions.cs 82.14% <57.14%> (-8.77%) ⬇️
...sonRpc/JsonRpcServerServiceCollectionExtensions.cs 87.34% <57.14%> (-1.48%) ⬇️
src/Server/LanguageServer.cs 77.82% <83.33%> (-0.06%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21f232...b25380c. Read the comment docs.

@mergify mergify bot merged commit a3a9674 into master Dec 5, 2020
@mergify mergify bot removed the merge Shipit! label Dec 5, 2020
@mergify mergify bot deleted the feature/registration-key branch December 5, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant